veghlaci05 commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1285833195
##########
service/pom.xml:
##########
@@ -221,6 +221,10 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-core</artifactId>
Review Comment:
Spring core is required for exception handling. Spring converts SqlException
to DataAccessException (which is runtime not checked). During the conversion,
based on the SQL codes for some exceptions (but not for all) spring also
localizes the exception message. This is the point where spring-core is
required. It is not used directly at all, no spring DI introduced in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
