deniskuzZ commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1288104122
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -445,17 +443,34 @@ private CompactionType checkForCompaction(final
CompactionInfo ci,
ci.getFullPartitionName(), exception);
}
}
- return compactionType;
+ }
+ if (compactionType != null) {
+ return createCompactionRequest(ci, compactionType);
+ } else {
+ return null;
}
}
+
+ private CompactionRequest createCompactionRequest(CompactionCandidate ci,
CompactionType type) {
Review Comment:
i don't like this refactor, since it doesn't create a complete
CompactionRequest and does some initialization afterward. in `requestCompaction
` you can see the complete request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
