henrib commented on code in PR #4569:
URL: https://github.com/apache/hive/pull/4569#discussion_r1304596370


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########


Review Comment:
   The logic that generates parameter names and add their values to the 
parameterVals might be easier to grasp with a comment and/or adding a variable 
to hold the parameter 'number' (parameterVals.size()).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to