dengzhhu653 commented on code in PR #4569:
URL: https://github.com/apache/hive/pull/4569#discussion_r1322637887
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -11831,8 +11831,35 @@ public NotificationEventResponse
getNextNotification(NotificationEventRequest rq
long lastEvent = rqst.getLastEvent();
List<Object> parameterVals = new ArrayList<>();
parameterVals.add(lastEvent);
+ // filterBuilder parameter is used for construction of conditional
clause in the select query
StringBuilder filterBuilder = new StringBuilder("eventId > para" +
parameterVals.size());
+ // parameterBuilder parameter is used for specify what types of
parameters will go into the filterBuilder
StringBuilder parameterBuilder = new StringBuilder("java.lang.Long para"
+ parameterVals.size());
+ /* A fully constructed query would like:
+ -> filterBuilder: eventId > para0 && catalogName == para1 && dbName ==
para2 && tableName == para3
+ || tableName == para4 && eventType != para5
+ -> parameterBuilder: java.lang.Long para0, java.lang.String para1,
java.lang.String para2
+ , java.lang.String para3, java.lang.String para4, java.lang.String
para5
+ */
+ if (rqst.isSetCatName()) {
+ parameterVals.add(rqst.getCatName());
+ parameterBuilder.append(", java.lang.String para" +
parameterVals.size());
+ filterBuilder.append(" && catalogName == para" + parameterVals.size());
+ }
+ if (rqst.isSetDbName()) {
+ parameterVals.add(rqst.getDbName());
+ parameterBuilder.append(", java.lang.String para" +
parameterVals.size());
+ filterBuilder.append(" && dbName == para" + parameterVals.size());
+ }
+ if (rqst.isSetTableNames()) {
+ filterBuilder.append(" && ");
+ for (String tableName : rqst.getTableNames()) {
+ parameterVals.add(tableName);
+ parameterBuilder.append(", java.lang.String para" +
parameterVals.size());
+ filterBuilder.append("tableName == para" + parameterVals.size()+ "
|| ");
+ }
+ filterBuilder.setLength(filterBuilder.length() - 4); // remove the
last " || "
Review Comment:
I think we should add parentheses to the filter with `tableName`s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
