saihemanth-cloudera commented on code in PR #4569: URL: https://github.com/apache/hive/pull/4569#discussion_r1330897292
########## standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0-beta-2.mssql.sql: ########## @@ -661,6 +661,8 @@ ALTER TABLE NOTIFICATION_LOG ADD CONSTRAINT NOTIFICATION_LOG_PK PRIMARY KEY (NL_ CREATE UNIQUE INDEX NOTIFICATION_LOG_EVENT_ID ON NOTIFICATION_LOG (EVENT_ID); +CREATE UNIQUE INDEX NOTIFICATION_LOG_UNIQUE_DB ON NOTIFICATION_LOG (DB_NAME, EVENT_ID); Review Comment: Both indices are required. There can be two different types of frequent queries in this table. 1. provided eventId, fetch all the events greater than the eventId. -- Will use index with event_id 2. provided eventId, dbName, table, fetch all the events of this table greater than the eventId. -- Will use index with db_name and event_id -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
