zabetak commented on code in PR #4692:
URL: https://github.com/apache/hive/pull/4692#discussion_r1338351754
##########
serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java:
##########
@@ -90,7 +90,7 @@ public void initialize(Configuration configuration,
Properties tableProperties,
Preconditions.checkArgument(this.columnNames.size() ==
this.columnTypes.size(),
"Column names must match count of column types");
- log.debug("SerDe initialized: [{}][{}]", this.configuration,
this.properties);
+ log.debug("{} initialized: [{}][{}]", getClass().getName(),
this.configuration, this.properties);
Review Comment:
For the log message here, I think it makes sense to add
`getClass().getName()`.
In the sub-classes though it may be cleaner if we just add a `private static
final Logger` field and get done with it. This may also be insignificantly more
efficient saving the call to `getClass().getName()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
