deniskuzZ commented on code in PR #4700: URL: https://github.com/apache/hive/pull/4700#discussion_r1338534182
########## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ########## @@ -177,39 +169,41 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mTable, ASTNode tabNameN ASTNode where = null; int whereIndex = deleting() ? 1 : 2; + if (children.size() > whereIndex) { where = (ASTNode)children.get(whereIndex); assert where.getToken().getType() == HiveParser.TOK_WHERE : "Expected where clause, but found " + where.getName(); + + if (copyOnWriteMode) { + String whereClause = ctx.getTokenRewriteStream().toString( + where.getChild(0).getTokenStartIndex(), where.getChild(0).getTokenStopIndex()); + + rewrittenQueryStr.append(" where "); + // Add the inverted where clause, since we want to hold the records which doesn't satisfy the condition. + rewrittenQueryStr.append(" not(").append(whereClause).append(")"); + // Add the file path filter that matches the delete condition. + rewrittenQueryStr.append(" and FILE__PATH in ("); + rewrittenQueryStr.append(" select `FILE__PATH` from ").append(getFullTableNameForSQL(tabNameNode)); Review Comment: i just used it to format the query for readability :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org