zhangbutao commented on code in PR #4700:
URL: https://github.com/apache/hive/pull/4700#discussion_r1348585126
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterBuilder.java:
##########
@@ -120,11 +121,20 @@ public HiveIcebergWriter build() {
new HiveFileWriterFactory(table, dataFileFormat, dataSchema, null,
deleteFileFormat, null, null, null,
skipRowData ? null : dataSchema);
+ boolean copyOnWriteMode =
RowLevelOperationMode.COPY_ON_WRITE.modeName().equalsIgnoreCase(
+ properties.get(TableProperties.DELETE_MODE)) &&
+ operation == Operation.DELETE;
Review Comment:
Can't we use one line? Is this line longer than 120 characters?
```suggestion
properties.get(TableProperties.DELETE_MODE)) && operation ==
Operation.DELETE;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
