abstractdog commented on code in PR #4758:
URL: https://github.com/apache/hive/pull/4758#discussion_r1349517664
##########
common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java:
##########
@@ -95,6 +95,9 @@ public void testConfProperties() throws Exception {
// Test HiveConf property variable substitution in hive-site.xml
checkHiveConf("test.var.hiveconf.property",
ConfVars.DEFAULTPARTITIONNAME.getDefaultValue());
+
+ // Test if LLAP_LRFU_HOTBUFFERS_PERCENTAGE is defined in HiveConf
+
Assert.assertTrue(HiveConf.getLlapDaemonConfVars().contains(ConfVars.LLAP_LRFU_HOTBUFFERS_PERCENTAGE.varname));
Review Comment:
if there are some options that are not considered to be present in
llapDaemonVarsSetLocal, then we should add them as exclusions in the unit test,
this way we can be future-proof:
1. dev adds a new "LLAP_" config
2. UT fails because it's not defined in llapDaemonVarsSetLocal
3. the dev has to think and add it to llapDaemonVarsSetLocal OR to the
exclusion list in the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
