mayankkunwar commented on code in PR #4758: URL: https://github.com/apache/hive/pull/4758#discussion_r1349844013
########## common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java: ########## @@ -95,6 +95,9 @@ public void testConfProperties() throws Exception { // Test HiveConf property variable substitution in hive-site.xml checkHiveConf("test.var.hiveconf.property", ConfVars.DEFAULTPARTITIONNAME.getDefaultValue()); + + // Test if LLAP_LRFU_HOTBUFFERS_PERCENTAGE is defined in HiveConf + Assert.assertTrue(HiveConf.getLlapDaemonConfVars().contains(ConfVars.LLAP_LRFU_HOTBUFFERS_PERCENTAGE.varname)); Review Comment: I see, this is good idea, I will added these changes, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org