SourabhBadhya commented on code in PR #4748:
URL: https://github.com/apache/hive/pull/4748#discussion_r1363846683
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table
mTable, ASTNode tabNameN
}
}
+ private boolean tryMetadataUpdate(ASTNode tree, Table table, ASTNode
tabNameNode) throws SemanticException {
+ TableName tableName = getQualifiedTableName(tabNameNode);
Review Comment:
@deniskuzZ
Can I use this config as the feature flag -
```
HIVE_OPTIMIZE_REPLACE_DELETE_WITH_TRUNCATE("hive.optimize.delete.all",
false,
"Optimize delete the entire data from table, use truncate instead"),
```
The purpose of this flag was to optimize the delete using truncate but I
think the config itself - `hive.optimize.delete.all` is generic.
`HIVE_OPTIMIZE_REPLACE_DELETE_WITH_TRUNCATE` - This needs a name change. Any
suggestions for the name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
