SourabhBadhya commented on code in PR #4748:
URL: https://github.com/apache/hive/pull/4748#discussion_r1363976524
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -62,7 +72,9 @@ protected void analyze(ASTNode tree, Table table, ASTNode
tabNameNode) throws Se
switch (tree.getToken().getType()) {
case HiveParser.TOK_DELETE_FROM:
operation = Context.Operation.DELETE;
- reparseAndSuperAnalyze(tree, table, tabNameNode);
+ if (!tryMetadataUpdate(tree, table, tabNameNode)) {
Review Comment:
Yes, I can see some improvements that can be done along this line since
there is a clear pathway defined for DELETE clauses when used in merge
statement -
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java#L204-L212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]