maheshk114 commented on code in PR #4636:
URL: https://github.com/apache/hive/pull/4636#discussion_r1374590582
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -9909,7 +9952,13 @@ private Operator genJoinOperator(QB qb, QBJoinTree
joinTree,
// generate a ReduceSink operator for the join
String[] srcs = baseSrc[i] != null ? new String[] {baseSrc[i]} :
joinTree.getLeftAliases();
if (!isCBOExecuted()) {
- srcOps[i] = genNotNullFilterForJoinSourcePlan(qb, srcOps[i], joinTree,
joinKeys[i]);
+ /*
+ * The condition srcOps[i] == OuterSrcOp is used to make sure that the
predicate for notnull check
+ * is added only for the outer query table.outerqueryCol
+ * even after the outer join condition
+ */
+ boolean outerNotInCheck = ( notInCheck && (srcOps[i] == OuterSrcOp) );
Review Comment:
nit : remove extra space after OuterSrcOp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
