Diksha628 commented on code in PR #4636:
URL: https://github.com/apache/hive/pull/4636#discussion_r1379607803
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -3603,7 +3603,29 @@ private Operator genFilterPlan(ASTNode searchCond, QB
qb, Operator input,
* push filters only for this QBJoinTree. Child QBJoinTrees have
already been handled.
*/
pushJoinFilters(qb, joinTree, aliasToOpInfo, false);
- input = genJoinOperator(qbSQ, joinTree, aliasToOpInfo, input);
+
+ /*
+ * Note that: in case of multi dest queries, with even one containing
a notIn operator, the code is not changed yet.
+ * That needs to be worked on as a separate bug
Review Comment:
done
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -3603,7 +3603,29 @@ private Operator genFilterPlan(ASTNode searchCond, QB
qb, Operator input,
* push filters only for this QBJoinTree. Child QBJoinTrees have
already been handled.
*/
pushJoinFilters(qb, joinTree, aliasToOpInfo, false);
- input = genJoinOperator(qbSQ, joinTree, aliasToOpInfo, input);
+
+ /*
+ * Note that: in case of multi dest queries, with even one containing
a notIn operator, the code is not changed yet.
+ * That needs to be worked on as a separate bug
+ * e.g.
+ * from t3 b
+ * INSERT OVERWRITE TABLE t4
+ * select *
+ * where b.age not in
+ * (select a.age
+ * from t3 a
+ * )
+ * order by age
+ * INSERT OVERWRITE TABLE t5
+ * select *
+ * where b.age in
+ * (select c.age
+ * from t3 c
+ * );
+ */
+ boolean notInCheck = (subQuery.getNotInCheck() != null &&
!qb.isMultiDestQuery() );
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
