saihemanth-cloudera commented on code in PR #4831: URL: https://github.com/apache/hive/pull/4831#discussion_r1380645041
########## ql/src/test/queries/clientpositive/partition_coltype_literals.q: ########## @@ -73,11 +73,11 @@ drop table if exists partcoltypeothers; create table partcoltypeothers (key int, value string) partitioned by (decpart decimal(6,2), datepart date); set hive.typecheck.on.insert=false; -insert into partcoltypeothers partition (decpart = 1000.01BD, datepart = date '2015-4-13') select key, value from src limit 10; +insert into partcoltypeothers partition (decpart = 1000.01BD, datepart = date '2015-04-13') select key, value from src limit 10; Review Comment: I don't agree with this change. This would be a breaking change if users were to use this patch in their production env (because they would now have to change their scripts/data). We intentionally specified this config 'hive.typecheck.on.insert=false' so that regardless of data format, partitions are created the way the data is inserted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
