saihemanth-cloudera commented on code in PR #4831:
URL: https://github.com/apache/hive/pull/4831#discussion_r1380649703
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -2689,11 +2690,32 @@ private void addPartitionsInternal(String catName,
String dbName,
List<MPartition> mParts = new ArrayList<>();
List<List<MPartitionPrivilege>> mPartPrivilegesList = new ArrayList<>();
List<List<MPartitionColumnPrivilege>> mPartColPrivilegesList = new
ArrayList<>();
+ List<MFieldSchema> partitionKeys = table.getPartitionKeys();
+ int[] dateIndices = IntStream.range(0, partitionKeys.size())
+ .filter(i ->
partitionKeys.get(i).getType().equalsIgnoreCase(ColumnType.DATE_TYPE_NAME))
Review Comment:
You have to validate partition column types only if this config is set
'HIVE_TYPE_CHECK_ON_INSERT'.
See this for reference:
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java#L1719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
