kasakrisz commented on code in PR #4869:
URL: https://github.com/apache/hive/pull/4869#discussion_r1405790350
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HivePushdownSnapshotFilterRule.java:
##########
@@ -116,15 +116,16 @@ private boolean setSnapShotId(RexNode op1, RexNode op2) {
return false;
}
- long snapshotId = literal.getValueAs(Long.class);
+ Long snapshotId = literal.getValueAs(Long.class);
RelOptTable relOptTable = getRelOptTableOf(op2);
if (relOptTable == null) {
return false;
}
RelOptHiveTable hiveTable = (RelOptHiveTable) relOptTable;
-
hiveTable.getHiveTableMD().setVersionIntervalFrom(Long.toString(snapshotId));
+ String snapshotIdText = snapshotId != null ? Long.toString(snapshotId) :
null;
Review Comment:
`String.valueOf(null)` returns string literal `"null"`. This is not a valid
snapshotId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
