deniskuzZ commented on code in PR #4517:
URL: https://github.com/apache/hive/pull/4517#discussion_r1410545851


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java:
##########
@@ -675,6 +676,24 @@ public List<String> createInsertValuesStmt(String 
tblColumns, List<String> rows,
     }
   }
 
+  public String createUpdatePreparedStmt(String tableName, List<String> 
columnNames,

Review Comment:
   why it's in DatabaseProduct, they are generic and not db specific? should we 
move them to TxnUtils and mark them as static?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to