deniskuzZ commented on code in PR #4517:
URL: https://github.com/apache/hive/pull/4517#discussion_r1410570623
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -901,23 +968,48 @@ private List<Long> getPartitionIdsViaSqlFilter(
String catName, String dbName, String tblName, String sqlFilter,
List<? extends Object> paramsForFilter, List<String> joinsForFilter,
Integer max)
throws MetaException {
+ return getPartitionFieldsViaSqlFilter(catName, dbName, tblName,
+ Arrays.asList("\"PART_ID\""), sqlFilter, paramsForFilter,
joinsForFilter, max);
+ }
+
+ /**
+ * Get partition fields for the query using direct SQL queries, to avoid
bazillion
+ * queries created by DN retrieving stuff for each object individually.
+ * @param catName MetaStore catalog name
+ * @param dbName MetaStore db name
+ * @param tblName MetaStore table name
+ * @param partColumns part fields want to get
+ * @param sqlFilter SQL filter to use. Better be SQL92-compliant.
+ * @param paramsForFilter params for ?-s in SQL filter text. Params must be
in order.
+ * @param joinsForFilter if the filter needs additional join statement, they
must be in
+ * this list. Better be SQL92-compliant.
+ * @param max The maximum number of partitions to return.
+ * @return List of partition objects.
+ */
+ public <T> List<T> getPartitionFieldsViaSqlFilter(
+ String catName, String dbName, String tblName, List<String> partColumns,
String sqlFilter,
+ List<? extends Object> paramsForFilter, List<String> joinsForFilter,
Integer max)
+ throws MetaException {
boolean doTrace = LOG.isDebugEnabled();
final String dbNameLcase = dbName.toLowerCase();
final String tblNameLcase = tblName.toLowerCase();
final String catNameLcase = normalizeSpace(catName).toLowerCase();
// We have to be mindful of order during filtering if we are not returning
all partitions.
String orderForFilter = (max != null) ? " order by " +
MetastoreConf.getVar(conf, ConfVars.PARTITION_ORDER_EXPR) : "";
+ String columns = partColumns.stream()
Review Comment:
keep it in 1 line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
