saihemanth-cloudera commented on code in PR #4893:
URL: https://github.com/apache/hive/pull/4893#discussion_r1412696912
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -234,7 +234,12 @@ private static void addHivePrivObject(Entity privObject,
Map<String, List<String
case DUMMYPARTITION:
case PARTITION:
// TODO: not currently handled
- return;
+ Table tbl = privObject.getTable();
+ List<String> col = tableName2Cols == null ? null :
+ tableName2Cols.get(Table.getCompleteName(tbl.getDbName(),
tbl.getTableName()));
+ hivePrivObject = new HivePrivilegeObject(privObjType, tbl.getDbName(),
tbl.getTableName(),
Review Comment:
Consider a bulk partition insert statement into a table, I think we would
generate so many hive privilege objects for a single table right?
If so, we should only be generating a single object per table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
