mayankkunwar commented on code in PR #4893:
URL: https://github.com/apache/hive/pull/4893#discussion_r1414921267
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -234,7 +234,12 @@ private static void addHivePrivObject(Entity privObject,
Map<String, List<String
case DUMMYPARTITION:
case PARTITION:
// TODO: not currently handled
- return;
+ Table tbl = privObject.getTable();
+ List<String> col = tableName2Cols == null ? null :
+ tableName2Cols.get(Table.getCompleteName(tbl.getDbName(),
tbl.getTableName()));
+ hivePrivObject = new HivePrivilegeObject(privObjType, tbl.getDbName(),
tbl.getTableName(),
Review Comment:
@saihemanth-cloudera but I think already when normal row is inserted without
partition
[here](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java#L198),
I see there also hive privilege objects would be generated many time, isn't
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
