simhadri-g commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1428899967
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2231,7 +2231,6 @@ public static enum ConfVars {
"If this is set to true the URI for auth will have the default
location masked with DEFAULT_TABLE_LOCATION"),
HIVE_ICEBERG_ALLOW_DATAFILES_IN_TABLE_LOCATION_ONLY("hive.iceberg.allow.datafiles.in.table.location.only",
false,
"If this is set to true, then all the data files being read should be
withing the table location"),
-
Review Comment:
Done
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -388,8 +390,11 @@ private void setHmsTableParameters(String
newMetadataLocation, Table tbl, TableM
// If needed set the 'storage_handler' property to enable query from Hive
if (hiveEngineEnabled) {
- parameters.put(hive_metastoreConstants.META_TABLE_STORAGE,
- "org.apache.iceberg.mr.hive.HiveIcebergStorageHandler");
+ String storageHandler =
parameters.get(hive_metastoreConstants.META_TABLE_STORAGE);
+ // Check if META_TABLE_STORAGE is not present or does not contain
ICEBERG_STORAGE_HANDLER
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
