deniskuzZ commented on code in PR #4761: URL: https://github.com/apache/hive/pull/4761#discussion_r1440675961
########## iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerStub.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * HiveIcebergStorageHandlerStub is used only for unit tests. + * Currently, we use it to achieve a specific thread interleaving to simulate conflicts in concurrent writes + * deterministically. + */ +public class HiveIcebergStorageHandlerStub extends HiveIcebergStorageHandler { + private static final Logger LOG = LoggerFactory.getLogger(HiveIcebergStorageHandlerStub.class); + + @Override + public HiveIcebergOutputCommitter getOutputCommitter() { + + try { + LOG.info("Using HiveIcebergStorageHandlerStub for unit tests"); + LOG.info("Sleeping thread: {} ", Thread.currentThread().getName()); + Thread.sleep(35000); Review Comment: > I tried the cyclicBarrier, both the threads would go to. sleep and never wake up... - it means that the code was not correct, `sleep` is a bad practice ########## iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerStub.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * HiveIcebergStorageHandlerStub is used only for unit tests. + * Currently, we use it to achieve a specific thread interleaving to simulate conflicts in concurrent writes + * deterministically. + */ +public class HiveIcebergStorageHandlerStub extends HiveIcebergStorageHandler { + private static final Logger LOG = LoggerFactory.getLogger(HiveIcebergStorageHandlerStub.class); + + @Override + public HiveIcebergOutputCommitter getOutputCommitter() { + + try { + LOG.info("Using HiveIcebergStorageHandlerStub for unit tests"); + LOG.info("Sleeping thread: {} ", Thread.currentThread().getName()); + Thread.sleep(35000); Review Comment: > I tried the cyclicBarrier, both the threads would go to. sleep and never wake up... it means that the code was not correct, `sleep` is a bad practice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
