akshat0395 commented on code in PR #4954:
URL: https://github.com/apache/hive/pull/4954#discussion_r1429180157
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java:
##########
@@ -48,9 +51,14 @@ public class StorageFormat {
public enum StorageHandlerTypes {
DEFAULT(),
- ICEBERG("\'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler\'",
+ ICEBERG("'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'",
"org.apache.iceberg.mr.hive.HiveIcebergInputFormat",
"org.apache.iceberg.mr.hive.HiveIcebergOutputFormat");
+ private static final List<StorageHandlerTypes> SUPPORTED_BY_STORED_BY =
Arrays
Review Comment:
nit: Can we rename this to SUPPORTED_STORED_BY?
##########
ql/src/test/results/clientnegative/create_table_stored_by_invalid3.q.out:
##########
@@ -0,0 +1 @@
+FAILED: SemanticException Cannot find class 'ICEBERG'
Review Comment:
Thanks for checking this out, the message looks clean and precise now.
Can you also handle case this ('ICEBERG') to keep the message consistent? We
can have something like `Unrecognized storage handler in STORED BY clause:
'ICEBERG'. Supported types = ICEBERG or FQCN of a storage handler.`
This should be an indicator enough for the user to remove the quotes. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
