okumin commented on code in PR #4954:
URL: https://github.com/apache/hive/pull/4954#discussion_r1430164116
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java:
##########
@@ -48,9 +51,14 @@ public class StorageFormat {
public enum StorageHandlerTypes {
DEFAULT(),
- ICEBERG("\'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler\'",
+ ICEBERG("'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler'",
"org.apache.iceberg.mr.hive.HiveIcebergInputFormat",
"org.apache.iceberg.mr.hive.HiveIcebergOutputFormat");
+ private static final List<StorageHandlerTypes> SUPPORTED_BY_STORED_BY =
Arrays
Review Comment:
I started feeling we may not need `StorageHandlerTypes.DEFAULT`. But it
seems to be a result of a discussion.
https://github.com/apache/hive/pull/4348#discussion_r1239887908
I'm thinking to rename it into like `NON_DEFAULT` for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
