zabetak commented on code in PR #4951:
URL: https://github.com/apache/hive/pull/4951#discussion_r1434113870
##########
ql/src/test/queries/clientpositive/materialized_view_rewrite_by_text_10.q:
##########
@@ -0,0 +1,11 @@
+-- Materialzed view definition has non-deterministic function
+set hive.support.concurrency=true;
+set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+
+CREATE TABLE EMPS (ENAME STRING, BIRTH_EPOCH_SECS INT) STORED AS ORC
TBLPROPERTIES ('transactional'='true');
+
+CREATE MATERIALIZED VIEW v_emp AS SELECT * FROM EMPS WHERE BIRTH_EPOCH_SECS <=
UNIX_TIMESTAMP();
Review Comment:
Actually thinking a bit more on this, it may be fine to allow the creation
of the materialized view as long as it does not create issues with query
rewriting and (incremental) refresh. I was thinking of use-cases where users
CREATE views and refresh them manually (let's say once every month) so in that
case UNIX_TIMESTAMP and other similar CURRENT_ functions may make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
