kasakrisz commented on code in PR #4951:
URL: https://github.com/apache/hive/pull/4951#discussion_r1434243023
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -14668,11 +14669,9 @@ private void validateCreateView()
}
throw new SemanticException(msg);
}
- if (!isValidAutomaticRewritingMaterialization()) {
- String errorMessage = "Only query text based automatic rewriting is
available for materialized view. " +
- getInvalidAutomaticRewritingMaterializationReason();
- console.printError(errorMessage);
- LOG.warn(errorMessage);
+ String validationWarningMessage =
automaticRewritingValidationResult.getErrorMessage();
Review Comment:
Renamed and disable rewrite if no rewrite alg is available.
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptMaterializationValidator.java:
##########
@@ -62,13 +65,16 @@
* - References to non-deterministic functions.
*/
public class HiveRelOptMaterializationValidator extends HiveRelShuttleImpl {
- static final Logger LOG =
LoggerFactory.getLogger(HiveRelOptMaterializationValidator.class);
+ public static final String UNSUPPORTED_BY_CALCITE_FORMAT =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
