aturoczy commented on code in PR #5010:
URL: https://github.com/apache/hive/pull/5010#discussion_r1454205269
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/MultiDataSourceJdbcResource.java:
##########
@@ -191,32 +191,23 @@ public Integer execute(ParameterizedCommand command)
throws MetaException {
* call using the query string obtained from {@link
ParameterizedBatchCommand#getParameterizedQueryString(DatabaseProduct)},
* the parameters obtained from {@link
ParameterizedBatchCommand#getQueryParameters()}, and the
* {@link org.springframework.jdbc.core.PreparedStatementSetter} obtained
from
- * {@link ParameterizedBatchCommand#getPreparedStatementSetter()} methods.
The batchSize is coming fomr the
- * {@link Configuration} object. After the execution, this method validates
the resulted number of affected rows using the
- * {@link ParameterizedBatchCommand#resultPolicy()} function for each
element in the batch.
+ * {@link ParameterizedBatchCommand#getPreparedStatementSetter()} methods.
The batchSize is coming from the
+ * {@link Configuration} object.
*
* @param command The {@link ParameterizedBatchCommand} to execute.
- * @return Returns an integer array,containing the number of affected rows
for each element in the batch.
*/
- public <T> int execute(ParameterizedBatchCommand<T> command) throws
MetaException {
+ public <T> void execute(ParameterizedBatchCommand<T> command) throws
MetaException {
Review Comment:
In Sql when you execute something it is a convention to return 0 if
everything is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
