deniskuzZ commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1461790050
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/MultiDataSourceJdbcResource.java: ########## @@ -191,32 +191,23 @@ public Integer execute(ParameterizedCommand command) throws MetaException { * call using the query string obtained from {@link ParameterizedBatchCommand#getParameterizedQueryString(DatabaseProduct)}, * the parameters obtained from {@link ParameterizedBatchCommand#getQueryParameters()}, and the * {@link org.springframework.jdbc.core.PreparedStatementSetter} obtained from - * {@link ParameterizedBatchCommand#getPreparedStatementSetter()} methods. The batchSize is coming fomr the - * {@link Configuration} object. After the execution, this method validates the resulted number of affected rows using the - * {@link ParameterizedBatchCommand#resultPolicy()} function for each element in the batch. + * {@link ParameterizedBatchCommand#getPreparedStatementSetter()} methods. The batchSize is coming from the + * {@link Configuration} object. * * @param command The {@link ParameterizedBatchCommand} to execute. - * @return Returns an integer array,containing the number of affected rows for each element in the batch. */ - public <T> int execute(ParameterizedBatchCommand<T> command) throws MetaException { + public <T> void execute(ParameterizedBatchCommand<T> command) throws MetaException { Review Comment: can we keep the jdbc signature (return result as we get)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org