veghlaci05 commented on code in PR #5010:
URL: https://github.com/apache/hive/pull/5010#discussion_r1463177819
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/queries/LatestTxnIdInConflictHandler.java:
##########
@@ -65,9 +66,12 @@ public String getParameterizedQueryString(DatabaseProduct
databaseProduct) throw
@Override
public SqlParameterSource getQueryParameters() {
+ List<String> types = new ArrayList<>(2);
Review Comment:
Very good point, moved to static constant.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/OnRenameFunction.java:
##########
@@ -132,12 +134,12 @@ public Void execute(MultiDataSourceJdbcResource
jdbcResource) throws MetaExcepti
}
MapSqlParameterSource paramSource = new MapSqlParameterSource()
- .addValue("oldDbName", StringUtils.lowerCase(oldDbName))
- .addValue("newDbName", StringUtils.lowerCase(newDbName))
- .addValue("oldTableName", StringUtils.lowerCase(oldTabName))
- .addValue("newTableName", StringUtils.lowerCase(newTabName))
- .addValue("oldPartName", oldPartName)
- .addValue("newPartName", newPartName);
+ .addValue("oldDbName", StringUtils.lowerCase(oldDbName), Types.VARCHAR)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
