deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474392029
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##########
@@ -38,16 +40,22 @@ public class AcidHouseKeeperService implements
MetastoreTaskThread {
private static final Logger LOG =
LoggerFactory.getLogger(AcidHouseKeeperService.class);
private Configuration conf;
- private boolean isCompactorEnabled;
private TxnStore txnHandler;
+ private String serviceName;
+
+ public void setServiceName(String serviceName) {
Review Comment:
1. mark `txnHandler` as protected and remove the getter
2. same with serviceName
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##########
@@ -38,16 +40,22 @@ public class AcidHouseKeeperService implements
MetastoreTaskThread {
private static final Logger LOG =
LoggerFactory.getLogger(AcidHouseKeeperService.class);
private Configuration conf;
- private boolean isCompactorEnabled;
private TxnStore txnHandler;
+ private String serviceName;
+
+ public void setServiceName(String serviceName) {
Review Comment:
1. mark `txnHandler` as protected and remove the getter
2. same with `serviceName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
