deniskuzZ commented on code in PR #4970: URL: https://github.com/apache/hive/pull/4970#discussion_r1478402920
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: ########## @@ -97,6 +97,9 @@ public class MetastoreConf { static final String ACID_HOUSE_KEEPER_SERVICE_CLASS = "org.apache.hadoop.hive.metastore.txn.AcidHouseKeeperService"; @VisibleForTesting + static final String ACID_COMPACTION_HOUSE_KEEPER_SERVICE_CLASS = Review Comment: was it committed? would be nice if we rename to ```` ACID_HOUSEKEEPER_SERVICE_CLASS - for aic txn COMPACTION_HOUSEKEEPER_SERVICE_CLASS - for compaction ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org