abstractdog commented on PR #5072: URL: https://github.com/apache/hive/pull/5072#issuecomment-1959268341
> At first glance it looks reasonable. I will take a better look tomorrow. > > One thing that I am not sure if it's beneficial is using the `serdeConstants` in tests. I assume that we don't want to change the values of such constants cause we risk breaking compatibility. By hardcoding the string values in tests we can guard against such changes. looks good to me I don't think we're about to change these constants, and I cannot think of a dev scenario where we risk compatibility due to the fact that we're using the constants in tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
