zabetak commented on PR #5072: URL: https://github.com/apache/hive/pull/5072#issuecomment-1959297107
> I don't think we're about to change these constants, and I cannot think of a dev scenario where we risk compatibility due to the fact that we're using the constants in tests If a developer changes `serdeConstants#INT_TYPE_NAME` from "int" to "integer" then if the tests are using the constant they will all pass without issues hiding the fact that the type name change and this may be a breaking change for end-users. Doing a holistic replace in tests would require very careful review without a significant gain. Also note that when we attempted a replace literals with constants in `ql/src/test` I got `84 files changed, 745 insertions(+), 745 deletions(-)` which is much more than what is currently is covered by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
