InvisibleProgrammer commented on code in PR #5118:
URL: https://github.com/apache/hive/pull/5118#discussion_r1516203028
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java:
##########
@@ -98,14 +98,12 @@ private String getDbTypeConfString() {// "ORACLE", "MYSQL",
"MSSQL", "POSTGRES"
}
public void beforeTest() throws Exception {
- getRule().before();
- if (!isDerby()) {// derby is handled with old QTestUtil logic (TxnDbUtil
stuff)
- getRule().install();
+ if (isDerby()) {
Review Comment:
If I understood it correctly, `DatabaseRule.before` initialises the docker
instance. So that change says docker will initialised once for the whole test
suite, not once per test case.
And we have to keep it for Derby as it sets the test directory
(`test.tmp.dir`).
Am I correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
