InvisibleProgrammer commented on PR #5118: URL: https://github.com/apache/hive/pull/5118#issuecomment-2019872713
Short version: LGTM. Long version: I checked it out with a PR that uses postgresql driver as a default one to check what happens if we want to run all the qtestst with postgres. Test run: http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5122/2/tests/ PR: https://github.com/apache/hive/pull/5122 Diff for the failing tests with only output diff (details below): https://github.com/apache/hive/compare/master...InvisibleProgrammer:hive:HIVE-28037 The PR itself reached it's goal: it had no problem with running multiple qtests with postgres. ## Different type of groups of test result ### Minor output differences There were tests that failed but with minor output diff differences. Typically, with having columns in an output in different order or with whitespace differences. I would consider them as a pass. We cannot address those issues as the difference comes from the differences between derby and postgres engine. Some examples: - default_constraint - unique constraints are shown in different order - create_with_constraints - key columns in different order - drop_partitions_filter.q - Some columns in different order, duplicate key error has different output ### Cannot run the tests with explicitly defined postgres driver as the tests are designed to run with postgres: There are some tests with a comment like `--!qt:database:postgres:q_test_country_table.sql` Those tests are failing with `unable to start docker container` if we add the `postgres` db parameter to the test execution. I don't think it worth investigating as they are designed to run with postgres and no other driver. Some examples: - qt_database_postgres.q - jdbc_partition_table_pruned_pcolumn.q ### Failed test cases that worth to fix: - https://issues.apache.org/jira/browse/HIVE-28150: Fix: cannot run Kudu and Blobstorage qtests with postgres driver as driver not found - https://issues.apache.org/jira/browse/HIVE-28151: Fix escape1.q and escape2.q tests with postgres driver - Fix partition_column_names_with_leading_and_trailing_spaces.q with postgres driver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
