deniskuzZ commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1572020032
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -8815,6 +8815,23 @@ These props are now enabled elsewhere (see commit
diffs). It would be better in
conf.set(AcidUtils.CONF_ACID_KEY, "true");
SessionState.get().getConf().set(AcidUtils.CONF_ACID_KEY, "true");
}
+
+ private void validateColumnCounts(String dest, Table table, Map<String,
String> partitionSpec,
+ int inColumnCnt, int outColumnCnt) throws SemanticException {
+
+ long staticPartitionColumnCnt = partitionSpec != null ?
+ partitionSpec.values().stream().filter(Objects::nonNull).count() : 0;
+
+ if (inColumnCnt + staticPartitionColumnCnt != outColumnCnt &&
Review Comment:
if it could be `inColumnCnt + staticPartitionColumnCnt == outColumnCnt where
staticPartitionColumnCnt is > 0 and in other cases it can be inColumnCnt ==
outColumnCnt` why do we even need to handle iceberg differently?
if(inColumnCnt + staticPartitionColumnCnt != outColumnCnt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
