difin commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1573084638


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -62,6 +65,17 @@ public AlterTableCompactOperation(DDLOperationContext 
context, AlterTableCompact
       throw new HiveException(ErrorMsg.NONACID_COMPACTION_NOT_SUPPORTED, 
table.getDbName(), table.getTableName());
     }
 
+    if (desc.getPartitionSpec() != null && 
!AlterTableUtils.isIdentityPartitionTable(table)) {
+      throw new HiveException("Compaction is not supported on the table " +
+          table.getDbName() + "." + table.getTableName() + " with non-identity 
partition spec");
+    }
+
+    if (desc.getPartitionSpec() != null && DDLUtils.isIcebergTable(table) && 

Review Comment:
   Done



##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -750,6 +750,10 @@ default boolean 
canUseTruncate(org.apache.hadoop.hive.ql.metadata.Table hmsTable
     return true;
   }
 
+  default boolean 
hasUndergonePartitionEvolution(org.apache.hadoop.hive.ql.metadata.Table table) {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to