wecharyu commented on code in PR #5246:
URL: https://github.com/apache/hive/pull/5246#discussion_r1598344960
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -5591,15 +5586,12 @@ private boolean needCheckPartitionLimit(int
requestSize) {
return partitionLimit > -1 && (requestSize < 0 || requestSize >
partitionLimit);
}
- private void checkLimitNumberOfPartitions(String tblName, int numPartitions,
int maxToFetch) throws MetaException {
- if (isPartitionLimitEnabled()) {
- int partitionLimit = MetastoreConf.getIntVar(conf,
ConfVars.LIMIT_PARTITION_REQUEST);
- int partitionRequest = (maxToFetch < 0) ? numPartitions : maxToFetch;
- if (partitionRequest > partitionLimit) {
- String configName = ConfVars.LIMIT_PARTITION_REQUEST.toString();
- throw new
MetaException(String.format(PARTITION_NUMBER_EXCEED_LIMIT_MSG, partitionRequest,
- tblName, partitionLimit, configName));
- }
+ private void checkLimitNumberOfPartitions(String tblName, int numPartitions)
throws MetaException {
+ int partitionLimit = MetastoreConf.getIntVar(conf,
ConfVars.LIMIT_PARTITION_REQUEST);
+ if (partitionLimit > -1 && numPartitions > partitionLimit) {
Review Comment:
Here we followed the existing code in `isPartitionLimitEnabled()`, do we
need change it?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -5563,26 +5563,21 @@ public List<Partition> get_partitions_with_auth(final
String dbName,
private void checkLimitNumberOfPartitionsByFilter(String catName, String
dbName,
String tblName, String
filterString,
int maxParts) throws
TException {
- if (isPartitionLimitEnabled()) {
+ if (needCheckPartitionLimit(maxParts)) {
Review Comment:
It's different. `needCheckPartitionLimit` use maxParts to determine if need
run the `checkLimitNumberOfPartitions`, while `checkLimitNumberOfPartitions`
checks if the matching `numPartitions` is greater than limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
