wecharyu commented on code in PR #5246:
URL: https://github.com/apache/hive/pull/5246#discussion_r1600370108
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -5563,26 +5563,21 @@ public List<Partition> get_partitions_with_auth(final
String dbName,
private void checkLimitNumberOfPartitionsByFilter(String catName, String
dbName,
String tblName, String
filterString,
int maxParts) throws
TException {
- if (isPartitionLimitEnabled()) {
+ if (needCheckPartitionLimit(maxParts)) {
Review Comment:
> 1. we execute the same function before and after db fetch
We only execute `needCheckPartitionLimit` before the count calls, we'll skip
fetching count if not need check limit
> 2. why we check count and fail post db call and not limit count inside of
it?
Not quite understand this words, afaik the limit check is used to avoid
fetching too many partitions in one calls. what do you mean of limit count
inside of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
