simhadri-g commented on code in PR #5241: URL: https://github.com/apache/hive/pull/5241#discussion_r1600875740
########## ql/src/test/queries/clientpositive/parquet_historical_timestamp.q: ########## @@ -1,3 +1,4 @@ +--! qt:timezone:Asia/Singapore Review Comment: No, it doesn't matter where it is. It affects the entire q file. Also, i checked the changed output , the intent of the test remains the same. The test was to check the reader output for the timestamp written in rome time zone . According to legacy conversion, the timestamp is converted to the reader's timezone. As a result , the output has moved ahead to 2019-01-01 08:30:30.111111111 which is the correct value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
