zabetak commented on code in PR #5241:
URL: https://github.com/apache/hive/pull/5241#discussion_r1601368826


##########
common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java:
##########
@@ -529,6 +529,7 @@ public enum ErrorMsg {
   PARQUET_FOOTER_ERROR(20022, "Failed to read parquet footer:"),
   PARQUET_UNHANDLED_TYPE(20023, "Unhandled type {0}", true),
   ORC_FOOTER_ERROR(20024, "Failed to read orc footer:"),
+  NOT_LEAP_YEAR(20025, "not a leap year", true),

Review Comment:
   I have the impression that this class holds messages that are targeting the 
end-user. I am not sure if it's appropriate for the use case here since we are 
not throwing this error anywhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to