wecharyu commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1606994350
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -1201,7 +1201,7 @@ public List<String> listPartitionNames(String catName,
String dbName, String tbl
public List<String> listPartitionNames(String catName, String dbName, String
tblName,
List<String> partVals, int maxParts) throws TException {
org.apache.hadoop.hive.metastore.api.Table table = getTempTable(dbName,
tblName);
- if (table == null) {
+ if (table == null || partVals == null) {
Review Comment:
Because `SessionHiveMetaStoreClient` extends `HiveMetaStoreClient`, it
should also check null for part_vals like `HiveMetaStoreClient`, and
`PartitionTree` should support empty or even null part_vals like metastore
server in my opinion.
Otherwise it would cause the inconsistent test results in
`TestListPartitions` for `HiveMetaStoreClient` and
`SessionHiveMetaStoreClient`, for example `testListPartitionsByValuesNoVals()`.
The master branch mark this test expect `MetaException`, but actually it should
return all partitions for empty part_vals. It could pass the test in master
because it throws `MetaException` when making part name for empty partVals in
`getNumPartitionsByPs`, which should be a bug in implement this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
