wecharyu commented on code in PR #5206:
URL: https://github.com/apache/hive/pull/5206#discussion_r1601403285
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java:
##########
@@ -121,8 +122,8 @@ List<Partition> addPartitions(List<Partition> partitions,
boolean ifNotExists)
* {@link MetaStoreUtils#getPvals(List, Map)}
*/
List<Partition> getPartitionsByPartitionVals(List<String> partialPartVals)
throws MetaException {
- if (partialPartVals == null || partialPartVals.isEmpty()) {
- throw new MetaException("Partition partial vals cannot be null or
empty");
+ if (MetaStoreUtils.arePartValsEmpty(partialPartVals)) {
Review Comment:
Add null check in `SessionHiveMetaStoreClient`, here we can follow the
server side behavior to support empty values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
