deniskuzZ commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1624775760
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -436,49 +526,34 @@ private CloseableIterable<T> openGeneric(FileScanTask
task, Schema readSchema) {
@SuppressWarnings("unchecked")
private CloseableIterable<T> open(FileScanTask currentTask, Schema
readSchema) {
- switch (inMemoryDataModel) {
+ switch (getInMemoryDataModel()) {
Review Comment:
why not just make fields protected to avoid all those getters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
