SourabhBadhya commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1629519719
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapred/MapredIcebergInputFormat.java:
##########
@@ -85,7 +90,8 @@ private static final class MapredIcebergRecordReader<T>
extends AbstractMapredIc
private final long splitLength; // for getPos()
MapredIcebergRecordReader(org.apache.iceberg.mr.mapreduce.IcebergInputFormat<T>
mapreduceInputFormat,
- IcebergSplit split, JobConf job, Reporter
reporter) throws IOException {
+ org.apache.hadoop.mapreduce.InputSplit split, JobConf job, Reporter
reporter)
Review Comment:
This is required since I have created a new split by the name of
IcebergMergeSplit which extends FileSplit.
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/MergeTaskProperties.java:
##########
@@ -19,12 +19,16 @@
package org.apache.hadoop.hive.ql.plan;
import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.ql.io.MergeSplitProperties;
import org.apache.hadoop.hive.ql.io.StorageFormatDescriptor;
import java.io.IOException;
+import java.util.Properties;
public interface MergeTaskProperties {
public Path getTmpLocation();
- public StorageFormatDescriptor getStorageFormatDescriptor() throws
IOException;
+ default MergeSplitProperties getSplitProperties() throws IOException {
+ return null;
Review Comment:
Done.
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java:
##########
@@ -184,6 +185,8 @@ public enum LlapIODescriptor {
private boolean useInputPathsDirectly;
+ private MergeSplitProperties mergeSplitProperties;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
