deniskuzZ commented on code in PR #5248:
URL: https://github.com/apache/hive/pull/5248#discussion_r1638366220
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -481,7 +484,23 @@ private void commitTable(FileIO io, ExecutorService
executor, OutputTable output
.map(x -> x.getJobConf().get(ConfVars.REWRITE_POLICY.varname))
.orElse(RewritePolicy.DEFAULT.name()));
- commitOverwrite(table, branchName, startTime, filesForCommit,
rewritePolicy);
+ Integer compactionPartSpecId = outputTable.jobContexts.stream()
+ .findAny()
+ .map(x ->
x.getJobConf().get(IcebergCompactionContext.COMPACTION_PART_SPEC_ID))
+ .map(Integer::valueOf)
+ .orElse(null);
+
+ String compactionPartitionPath = outputTable.jobContexts.stream()
Review Comment:
could we please use consistent naming, not
````
compactionPartSpecId/COMPACTION_PART_SPEC_ID
compactionPartitionPath/COMPACTION_PARTITION_PATH
````
why do we need compaction in name? how about:
````
partitionSpecId/PARTITION_SPEC_ID
partitionPath/PARTITION_PATH
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
