difin commented on code in PR #5248:
URL: https://github.com/apache/hive/pull/5248#discussion_r1640356967
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -746,6 +746,11 @@ default void
validatePartSpec(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
throw new UnsupportedOperationException("Storage handler does not support
validation of partition values");
}
+ default void validatePartAnySpec(org.apache.hadoop.hive.ql.metadata.Table
hmsTable, Map<String, String> partitionSpec)
Review Comment:
Validates that the provided `partitionSpec` is a valid according to the
current or past table partitioning.
The existing method `validatePartSpec` validates that the spec is valid
based on current table partitioning only. This isn't enough for Iceberg
compaction on partition level with evolution because the partition spec
provided in compaction command may correspond for an old partitioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
