deniskuzZ commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1639646017
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -459,9 +474,14 @@ private void commitTable(FileIO io, ExecutorService
executor, OutputTable output
deleteFiles.addAll(writeResults.deleteFiles());
replacedDataFiles.addAll(writeResults.replacedDataFiles());
referencedDataFiles.addAll(writeResults.referencedDataFiles());
+ mergedAndDeletedFiles.addAll(writeResults.mergedAndDeletedFiles());
}
- FilesForCommit filesForCommit = new FilesForCommit(dataFiles, deleteFiles,
replacedDataFiles, referencedDataFiles);
+ dataFiles.removeIf(dataFile -> mergedAndDeletedFiles.contains(new
Path(String.valueOf(dataFile.path()))));
+ deleteFiles.removeIf(deleteFile -> mergedAndDeletedFiles.contains(new
Path(String.valueOf(deleteFile.path()))));
+
+ FilesForCommit filesForCommit = new FilesForCommit(dataFiles, deleteFiles,
replacedDataFiles, referencedDataFiles,
Review Comment:
isn't there default constructor that would use Collections.emptySet() if not
provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
