deniskuzZ commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1642256311
##########
ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveRecordReader.java:
##########
@@ -88,14 +90,26 @@ public CombineHiveRecordReader(InputSplit split,
Configuration conf,
}
}
+ FileSplit inputSplit;
// create a split for the given partition
- FileSplit fsplit = new FileSplit(hsplit.getPaths()[partition], hsplit
- .getStartOffsets()[partition], hsplit.getLengths()[partition], hsplit
- .getLocations());
+ if (inputFormat instanceof CombineHiveInputFormat.MergeSplit) {
+ if (mrwork == null) {
Review Comment:
could we extract this part to a private method and reuse
````
if (mrwork == null) {
mrwork = (MapWork) Utilities.getMergeWork(jobConf);
if (mrwork == null) {
mrwork = Utilities.getMapWork(jobConf);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
